Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baremetal worker doc #107

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rokej
Copy link
Contributor

@rokej rokej commented Jun 3, 2022

Signed-off-by: Roke Jung [email protected]

Description of the change(s):

  • Update the documentation on provisioning a hypershift hosted cluster on bare-metal

Why do we need this PR:

Issue reference:

Test API/Unit - Success

N/A

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 3, 2022
@rokej rokej requested review from jnpacker and philipwu08 June 3, 2022 19:36
@jnpacker
Copy link
Member

jnpacker commented Jun 6, 2022

FYI @cadawson . We should probably get an issue to incorporate this into our official doc stream.

@@ -129,31 +129,202 @@ Upon scaling up a NodePool, a Machine will be created, and the CAPI provider wil

Upon scaling down a NodePool, Agents will be unbound from the corresponding cluster. However, you must boot them with the Discovery Image once again before reusing them.

To use the Agent platform, the Infrastructure Operator must first be installed. Please see [here](https://hypershift-docs.netlify.app/how-to/agent/create-agent-cluster/) for details.
To use the Agent platform, the Infrastructure Operator must first be installed. Please see [here](https://hypershift-docs.netlify.app/how-to/agent/create-agent-cluster/) for details or you can enable it through the multiclusterengine resource.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention we only officially support AI on local-host, using the ACM/MCE hub as the hosting service cluster.


###### Provision a hosted cluster

Create `HostedCluster` and `NodePool` on the MCE cluster. These will be referenced by `HypershiftDeployment` to provision the hosted cluster on the target hosting cluster. We are going to create the `HostedCluster`, `NodePool` and `HypershiftDeployment` all in `default` namespace on the MCE cluster. On the hosting cluster, hypershift deployment will create `HostedCluster` and `NodePool` in `clusters` namespace.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to make this work? My understanding is it will only work for the hub.

Signed-off-by: Roke Jung <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci
Copy link

openshift-ci bot commented Jun 25, 2022

@rokej: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants